Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework V2 #102
Framework V2 #102
Changes from 54 commits
e817592
ee75d8a
02006b2
151434c
af83713
4260458
4355dfa
29909da
63121c8
b6d83d5
9fbb075
f23bbe8
45beee6
d8350d1
415a236
146ae35
4eeddf7
803dddc
1876af8
cbe0901
c2e70ab
136c318
a3bdb49
ab04d15
8b448f6
eaf63bd
bd9ff87
c8de4cc
644687b
4bcf458
31bd350
97f9320
dc96765
73d8f0b
a912fab
ab4544a
db4ae13
4eb0583
5a6d171
22bd6d6
f5a483a
0e67327
c2cc0f2
552bccd
50d4cd5
c0b5d73
33698fc
cd3c30a
0e4281d
0f69480
6dcef9a
242a20f
be16910
54074b9
11488b1
d2909e7
52c1a06
7466616
b7ff4de
1105527
f3cb041
daba6a7
d714fcb
6c8ffb0
a4916b4
69b83a3
2213a3c
96e1f58
c9ea90e
e34ed9c
c68f74e
a73f0a0
7405c1f
55792e0
d81dd2a
399c89e
dff85bd
e44076b
8dfe731
6cd3232
ceae30f
3ba0cd1
ecf9791
569428c
f5e2ac0
8ef5482
23dedb9
d8ef76a
d5e2929
ee4fc6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't we abstracted this part?
Might also be a good idea to have a small section with all the list of possible hooks, beside the regular routes (init, shutdown, onRequest, onStart).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, readme will need to be updated.