Feat 6396 Postmark Messaging Adapter #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
approved these changes
Oct 13, 2023
stnguyen90
approved these changes
Nov 1, 2023
Meldiron
approved these changes
Nov 21, 2023
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
thinkverse |
|
@thinkverse Will reach out soon. Trying to put forms together for everyone. Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a simple Postmark Email adapter.
Test Plan
Included test suite has been marked as skipped given no API key is available in CI. But the test plan is described as follows:
While Postmark provides an API key for testing the key only verifies the data is correct. So I opted to include a new E2E test for Postmark. To run it, a Postmark account with a domain attached and two email accounts are required.
Servers > My First Server > API tokensutopia-php/messagingroot directory in a terminal.composer installto install PHPUnit and related packages.Now the E2E can be executed with the provided API key as the environment variable
POSTMARK_API_KEY. TheTEST_EMAILandTEST_FROM_EMAILmust be open, real email addresses and are required to be of the same domain. Namely, the same domain as your Sender Signature.Included below is a video showing the E2E test running:
Screen.Recording.2023-10-02.at.04.25.07.mov
Related PRs and Issues
Closes: appwrite/appwrite#6396
Have you read the Contributing Guidelines on issues?
Yes. 👍