Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Pusher Messaging Adapter #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Pusher Messaging Adapter #36

wants to merge 1 commit into from

Conversation

kit-t
Copy link

@kit-t kit-t commented Oct 4, 2023 •
edited
Loading

What does this PR do?

Adds a new Push Adapter for sending push notification via Pusher.

Test Plan

  • Create a free account on Pusher
  • Add the following environment variables
    • PUSHER_INSTANCE_ID: <Pusher Beams instance id, can be found in the dashboard under Keys > Credentials>
    • PUSHER_SECRET_KEY: <Pusher Beams secret key, can be found in the dashboard under Keys > Credentials>
    • PUSHER_TO: <userId e.g. 'test-user-id'>
  • Run test against tests/e2e/Push/PusherTest.php

Related PRs and Issues

resolves appwrite/appwrite#6398

Have you read the Contributing Guidelines on issues?

Yes

@kit-t kit-t mentioned this pull request Oct 4, 2023
Closed
5 tasks
@kit-t
Copy link
Author

kit-t commented Oct 24, 2023

Hi @wess, this is ready for review 🙂

@stnguyen90 stnguyen90 self-requested a review October 31, 2023 15:29
stnguyen90
stnguyen90 requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you please attach a screenshot of a successful test to verify it all works?

@kit-t
Copy link
Author

kit-t commented Oct 31, 2023

Looks good! Would you please attach a screenshot of a successful test to verify it all works?

Sure.
image

@stnguyen90 stnguyen90 self-requested a review November 1, 2023 00:30
stnguyen90
stnguyen90 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@kit-t
Copy link
Author

kit-t commented Apr 9, 2024

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Discord username: _kit_t

Thanks!

@gewenyu99
Copy link

Will reach out soon after we put together forms for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with Pusher Adapter
4 participants
@kit-t @gewenyu99 @stnguyen90 @Meldiron