Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SMSApi Messaging Adapter #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nooras
Copy link

@nooras nooras commented Oct 7, 2023

What does this PR do?

This PR implements SMSApi messaging adapter

Test Plan

To execute the SMSApi E2E test suite, you will need a SMSApi account with certain requirements. Please follow these steps:

  1. Create a SMSApi account
  2. Set up Sender Information
  3. Create a token
  4. Download this repository & install necessary package by
composer install 
  1. Run E2E test by replacing your TOKEN, DESTINATION_NUMBER & SENDERNAME in following command.
    (Note: Go to tests/e2e/SMS/SMSApiTest.php file. Do un-comment the commented line & comment the markTestSkipped line [Line no:28])
SMSAPI_AUTH_TOKEN="TOKEN" SMSAPI_TO="DESTINATION_NUMBER" SMSAPI_FROM="SENDERNAME_FROM_SMSApi" ./vendor/bin/phpunit tests/e2e/SMS/SMSApiTest.php

Related PRs and Issues

Closes: #6402

Have you read the Contributing Guidelines on issues?

Yes

@fanatic75 fanatic75 requested a review from wess October 19, 2023 15:03
@wess
Copy link
Contributor

wess commented Oct 19, 2023

Code looks good please be sure to run pint/linter before we can approve

@nooras
Copy link
Author

nooras commented Oct 19, 2023

Code looks good please be sure to run pint/linter before we can approve

HI @wess
I have already run pint in my local.
Here is the screenshot. Let me know in case of any changes are required.
image

Thanks

@tessamero
Copy link

Hello @nooras

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@nooras
Copy link
Author

nooras commented Nov 15, 2023

Hello @nooras

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@tessamero I have already tried test(phpunit,pint) in my local also have added screenshot on top. Can you please guide me how to resolve this issue.

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with SMSApi Adapter
4 participants