Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 7714 adding semaphore messaging adapter #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

7777chaitanya
Copy link

@7777chaitanya 7777chaitanya commented Mar 13, 2024

What does this PR do?

This PR adds Semaphore SMS adapter.

Test Plan

  • I verified the response structure of this adapter to match with the response structure of the exisiting SMS adapters.
  • I verified that the new adapter is handling both sucess and failure responses. I have added the sample responses in the new adapter file for your reference

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes, I have read the contributing guidelines. Starting from naming of the branch to writing tests to linting, I have double checked if I am complying with the contributing guidelines.

@7777chaitanya
Copy link
Author

Dear reviewer, I am attaching the images that prove the working and the lint success of this adapter for your reference.

Success response

Screenshot from 2024-03-13 06-31-34

Failure response

Screenshot from 2024-03-13 06-32-48

Lint success

Screenshot from 2024-03-13 06-42-52

@7777chaitanya 7777chaitanya force-pushed the feat-7714-adding-semaphore-messaging-adapter branch from 1ea4259 to d278698 Compare March 13, 2024 08:36
@moshOntong-IT
Copy link

I hope someone will review this PR

@moshOntong-IT
Copy link

Any update for this PR?

@stnguyen90 stnguyen90 self-requested a review May 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants