Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bug same path #84

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Move bug same path #84

merged 4 commits into from
Oct 18, 2023

Conversation

fogelito
Copy link
Contributor

@fogelito fogelito commented Aug 23, 2023 •
edited
Loading

Fix bug when source and target are identical the file gets deleted.
appwrite/appwrite#5814

@fogelito fogelito requested a review from christyjacob4 August 23, 2023 07:56
@joeyouss joeyouss mentioned this pull request Aug 23, 2023
Closed
2 tasks
abnegate
abnegate requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's return true instead of throwing an exception. Since the file will definitely be at $target, any code relying on it will still work, and it'll be easier to consume the library

@fogelito fogelito requested a review from abnegate August 27, 2023 08:07
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
@abnegate abnegate merged commit 296a979 into main Oct 18, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fogelito @abnegate