Added macos universal build. #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new macos_arch build option that allows specifying universal, x86_64, or arm64 (apple silicon). This defaults to universal which includes both x86_64 and arm64 builds.
|
I see that the CI builds failed due to missing the FMODUSER and FMODPASS variables. Where do I set these in my fork to allow the CI builds to work? And should their values be my personal FMOD username and password? |
|
Okay after some poking around it looks like maybe pull requests from forks are not possible with the CI builds right now (issue #95) and a work-around is being a contributor in the project and creating a branch there instead of from a fork (pull-requests #93 and #96). What should be the way forward here? Happy to help however I can! |
|
I just sent you an invitation so you can be contributor on this repo |
|
Okay thanks, I will open a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new macos_arch build option that allows specifying universal, x86_64, or arm64 (apple silicon). This defaults to universal which includes both x86_64 and arm64 builds. Both the FMOD libraries and godot-cpp library provide macos universal builds now so this allows fmod-gdnative to be able to be built for and run on macos arm64 architecture.
Without these changes running a godot project with the fmod-gdnative library on macos arm64 gives the following error:
Can't open dynamic library: .../addons/fmod/libs/osx/libGodotFmod.osx.release.64.dylib, error: dlopen(.../addons/fmod/libs/osx/libGodotFmod.osx.release.64.dylib, 0x0002): tried: '.../addons/fmod/libs/osx/libGodotFmod.osx.release.64.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/lib/libGodotFmod.osx.release.64.dylib' (no such file).