Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Rename identifiers #193

Merged
merged 10 commits into from
Mar 3, 2019
Merged

Rename identifiers #193

merged 10 commits into from
Mar 3, 2019

Conversation

tygamvrelis
Copy link
Member

@tygamvrelis tygamvrelis commented Mar 3, 2019

This picks up where #189 left off for #159 and primarily works on renaming identifiers, argument names, etc. Also refactored RobotGoal/State and Communication.h/.cpp

Testing

  • Robot_F4 and Robot_F7 build & unit tests pass

Remaining work

  • Need to do this identifier renaming in component/UdpDriver too, did not get a chance to do that yet
  • There were a few cases where I used the namespace directive to introduce the soccerbot namespace to avoid excessively long names (I put a TODO besides these). I think we can get rid of these once we separate the threads into different files

Copy link
Member

@rfairley rfairley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise looks good. Thanks for going through these files! Code looks a lot more uniform and clean now.

Common/app/Communication.cpp Outdated Show resolved Hide resolved
Common/include/uart_handler.h Outdated Show resolved Hide resolved
Common/include/uart_handler.h Show resolved Hide resolved
Common/app/rx_helper.cpp Outdated Show resolved Hide resolved
Common/component/DSP/dsp.h Outdated Show resolved Hide resolved
Common/component/DSP/dsp.h Show resolved Hide resolved
Common/component/Dynamixel/Dynamixel.cpp Outdated Show resolved Hide resolved
Common/component/MPU6050/MPU6050.cpp Outdated Show resolved Hide resolved
Common/component/MPU6050/MPU6050.cpp Outdated Show resolved Hide resolved
Common/include/uart_handler.h Show resolved Hide resolved
Copy link
Member

@rfairley rfairley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rfairley
Copy link
Member

rfairley commented Mar 3, 2019

Going to be making some edits to change some of the current class and file names to be more consistent with the style guide (will work from this branch and open a separate PR - as changes here look good). Can also do the Udp identifiers while at it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants