remove the #[repr(C) attributions #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added because uncertainty on whether the C interface will be directly provided in the crate itself. Since then I have resolved to use uuid-rs/xuuid.c instead. Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Dylan-DPC-zz
approved these changes
Jul 18, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
418: remove the #[repr(C) attributions r=Dylan-DPC a=kinggoesgaming **I'm submitting a(n)** (bug fix|deprecation|feature|refactor|removal|other) # Description Remove the `#[repr(C)]` for `Variant` and `Version`. # Motivation These were added because uncertainty on whether the C interface will be directly provided in the crate itself. Since then I have resolved to use uuid-rs/xuuid.c instead. # Tests No test changes are needed # Related Issue(s) N/A Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus Closes #431 [Changeset since the last release](0.7.4...master) Includes: - #427 - #419 - #424 - #418 - #413 - #407 - #404 - #400 - #399 - #398 - #397 - #396 - #394 - #393 - #390 - #389 - #388 I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild). Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) (bug fix|deprecation|feature|refactor|removal|other)
Description
Remove the
#[repr(C)]forVariantandVersion.Motivation
These were added because uncertainty on whether the
C interface will be directly provided in the crate itself.
Since then I have resolved to use uuid-rs/xuuid.c instead.
Tests
No test changes are needed
Related Issue(s)
N/A