Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js 8.x support #410

Closed
ctavan opened this issue Mar 31, 2020 · 4 comments
Closed

Drop Node.js 8.x support #410

ctavan opened this issue Mar 31, 2020 · 4 comments

Comments

@ctavan
Copy link
Member

ctavan commented Mar 31, 2020

Node.js 8.x reached EOL on 2019-12-31.

Many of our development dependencies (prettier, rollup) already removed support for Node 8.x.

I would like to remove official support for node 8.x as well. This will require a major version bump.

Thoughts?
@broofa
Copy link
Member

broofa commented Mar 31, 2020

Do it. There's already precedent for only supporting maintained node releases in the form of #275.

ctavan added a commit that referenced this issue Mar 31, 2020
@ctavan
feat: drop Node.js 8.x support
5424e30 
BREAKING CHANGE: Drop official support for Node.js 8.x since the 8.x
line has reached end-of-life on 2019-12-31. The library is likely to
continue to work with Node.js 8.x, we simply won't provide official
support for it.

Fixes #410.
ctavan added a commit that referenced this issue Mar 31, 2020
@ctavan
feat: drop Node.js 8.x support
8900b0c 
BREAKING CHANGE: Drop official support for Node.js 8.x since the 8.x
line has reached end-of-life on 2019-12-31. The library is likely to
continue to work with Node.js 8.x, we simply won't provide official
support for it.

Fixes #410.
@ctavan ctavan mentioned this issue Mar 31, 2020
Closed
ctavan added a commit that referenced this issue Mar 31, 2020
@ctavan
feat: drop Node.js 8.x support
4009fa0 
BREAKING CHANGE: Drop official support for Node.js 8.x since the 8.x
line has reached end-of-life on 2019-12-31. The library is likely to
continue to work with Node.js 8.x, we simply won't provide official
support for it.

Fixes #410.
@ctavan
Copy link
Member Author

ctavan commented Mar 31, 2020

As pointed out by @broofa, in #275 the preferred policy was "supported node versions + one legacy version".

This seems to make sense as long as popular runtimes like Google Cloud Functions still support Node.js 8.x

@ctavan ctavan closed this as completed Mar 31, 2020
@TrySound
Copy link
Member

Looks like google cloud packages are almost all migrated away from node 8.

@ctavan
Copy link
Member Author

ctavan commented Apr 14, 2020

@TrySound thanks for the notice.

I still think that, given the wide adoption of this module, the "supported node versions + 1 unsupported" is still a good policy and puts less pressure on the ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: drop Node.js 8.x support uuidjs/uuid
3 participants
@broofa @ctavan @TrySound