build: remove babel-plugin-add-module-exports #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have deprecated deep requires we no longer need the module.exports from the individual v*.js files. Since we now ship plain, non-babled deep require files on the top level of the npm package for legacy CommonJS deep-require support we can compensate for the lack of module.exports in there and instead simply access the "default" export of the algorithm-specific modules. This change was inspired by webpack/webpack#7973 (comment)
ctavan
force-pushed
the
remove-babel-plugin-add-module-exports
branch
2 times, most recently
from
4b65163
to
8c8ac91
Compare
broofa
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have deprecated deep requires we no longer need the module.exports from the individual v*.js files.
Since we now ship plain, non-babled deep require files on the top level of the npm package for legacy CommonJS deep-require support we can compensate for the lack of module.exports in there and instead simply access the "default" export of the algorithm-specific modules.
This change was inspired by webpack/webpack#7973 (comment)
I stumbled upon this one on my struggle to finally make some progress on #402. While this doesn't help with #402 it's certainly no longer necessary and anything we can do to simplify our build pipeline is always welcome I guess.