Skip to content

Commit

Permalink
move lints from rustflags to Cargo.toml
Browse files Browse the repository at this point in the history
This prevents unnecessary rebuilds when mixing runs of `cargo clippy` and other
cargo commands (e.g., `cargo c && cargo clippy && cargo c` no longer rebuilds).
  • Loading branch information
jtracey committed Sep 29, 2024
1 parent aaa541a commit 5994759
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 18 deletions.
11 changes: 0 additions & 11 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,2 @@
[target.x86_64-unknown-redox]
linker = "x86_64-unknown-redox-gcc"

[target.'cfg(clippy)']
rustflags = [
"-Wclippy::use_self",
"-Wclippy::needless_pass_by_value",
"-Wclippy::semicolon_if_nothing_returned",
"-Wclippy::single_char_pattern",
"-Wclippy::explicit_iter_loop",
"-Wclippy::if_not_else",
]

21 changes: 14 additions & 7 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -559,10 +559,17 @@ panic = "abort"
strip = true

[lints.clippy]
multiple_crate_versions = { level = "allow", priority = 1 }
cargo_common_metadata = { level = "allow", priority = 1 }
uninlined_format_args = { level = "allow", priority = 1 }
missing_panics_doc = { level = "allow", priority = 1 }
all = "deny"
cargo = "warn"
pedantic = "deny"
multiple_crate_versions = "allow"
cargo_common_metadata = "allow"
uninlined_format_args = "allow"
missing_panics_doc = "allow"

needless_pass_by_value = "warn"
semicolon_if_nothing_returned = "warn"
single_char_pattern = "warn"
explicit_iter_loop = "warn"
if_not_else = "warn"

all = { level = "deny", priority = -1 }
cargo = { level = "warn", priority = -1 }
pedantic = { level = "deny", priority = -1 }

0 comments on commit 5994759

Please sign in to comment.