Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo tree bug + CICD issues #1480

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Conversation

rivy
Copy link
Member

@rivy rivy commented Apr 15, 2020

adds work-around for bugs caused by absorption of cargo tree into cargo

ref: GH:rust-lang/cargo#8062

Fixes: #1478

@rivy rivy requested a review from sylvestre April 15, 2020 15:16
- 13 minutes to CI success/failure response from AppVeyor (approx median time); down from 45 minutes

.# [why]

Most of the testing done on AppVeyor is redundant with that done in the GHA:CICD.
With prior settings, AppVeyor was taking about 40 minutes to an hour (median ~ 45
minutes) to report success/failure. In contrast, the GHA:CICD workflow usually completes
in about 13 minutes (median).

AppVeyor job times are approximately 5 to 8 minutes per build and are done sequentially
with no report until all build jobs are complete (whether "allow failure" or not).
- 10 minutes to CI success/failure response from Travis CI (approx median time); down from 60 minutes

.# [why]

Most of the testing done on Travis CI is redundant with that done in the GHA:CICD.
With prior settings, Travis CI was taking about an hour (median) to report success/failure.
In contrast, the GHA:CICD workflow usually completes in about 13 minutes (median).

Travis CI job times are highly variable taking between 3 and 20 minutes per build.
Builds are run with some parallelism, and a report is submitted as soon as the
non-"allow failure" jobs are completed.
@rivy rivy changed the title Fix cargo tree bug Fix cargo tree bug + CICD issues Apr 15, 2020
@rivy rivy mentioned this pull request Apr 15, 2020
@rivy
Copy link
Member Author

rivy commented Apr 15, 2020

I'll merge this as soon as the AppVeyor CI completes successfully.

@rivy rivy merged commit 129331c into uutils:master Apr 15, 2020
@rivy rivy deleted the fix.cargo-tree-bug branch April 15, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA:CICD broken by cargo tree in nightly
2 participants