-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy Pedantic Acceptable Commits #6738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the changes are easily readable and clearly correspond to each clippy lint. This could be merged as-is.
Bonus points if you also change the two small things that samueltardieu and I mentioned (preallocating the string and fixing a misleading variable name).
Change `bytes` to `hex`. Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
could you please merge the two last commits into the relevant commit? git rebase -i origin/main |
GNU testsuite comparison:
|
These are the commits which you said you would accept.
#6720