Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df: error on over-mounted device #7116

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

jfinkels
Copy link
Collaborator

Make df error when two devices are mounted at the same directory and the earlier one is given as a positional argument to df. This is called "over-mounting". After this commit, an error message is printed like this:

df: cannot access '/dev/loop1': over-mounted by another device

Fixes #3970

(This is essentially identical to #4316, just rebased on main with a couple minor merge conflict fixes.)

@jfinkels jfinkels force-pushed the df-error-on-overmounted branch from 7b89d90 to ce7dda4 Compare January 11, 2025 03:46
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/df/over-mount-device is no longer failing!

1 similar comment
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/df/over-mount-device is no longer failing!

Make `df` error when two devices are mounted at the same directory and
the earlier one is given as a positional argument to `df`. This is
called "over-mounting". After this commit, an error message is printed
like this:

    df: cannot access '/dev/loop1': over-mounted by another device

Fixes uutils#3970

Co-authored-by: Jeffrey Finkelstein <jeffrey.finkelstein@protonmail.com>
@jfinkels jfinkels force-pushed the df-error-on-overmounted branch from c098b83 to 02e49a4 Compare January 11, 2025 17:41
@jfinkels jfinkels marked this pull request as ready for review January 11, 2025 17:41
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/df/over-mount-device is no longer failing!

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/df/over-mount-device is no longer failing!

well done :)

@sylvestre sylvestre merged commit da40b35 into uutils:main Jan 12, 2025
65 checks passed
sylvestre added a commit that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df: should error on over-mounted device, but doesn't
3 participants