Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Final update to bump python dependency versions and change the Readme #135

Merged
merged 21 commits into from
May 20, 2024

Conversation

bobvdvelde
Copy link
Contributor

@bobvdvelde bobvdvelde commented May 14, 2024

Dependency updates + fix of breaking changes & a 'no longer maintained' Readme.md

Closes all other PRs 🎉


A final PR to 'close them all'. 👋 🫡

Assumptions

This is the farewell PR for OSD2F maintainance. It assumes anyone interested in reusing/extending the code deserves a tidy final release with (at least at the time of publishing) up-to-date depencies and working build system.

For pragmatic reasons, the javascript side is not fully updated, as this would entail a major migration for the Vue framework (v2->v3).

Information about the status of this repository has been added to the readme (preview: here )

Usage / Minimal Example

Instructions on how to verify changes this PR by running code

before

echo "stuff breaks"
pytest
flake8
mypy ./osd2f/ --ignore-missing-imports
npm audit
ValueError: Stuff broke!

after

echo "stuff breaks"
pytest
flake8
mypy ./osd2f/ --ignore-missing-imports
npm audit
Success!

Checklist

  • Added tests if appropriate (and it should always be)
  • Created new issues when required
  • rinsed out the coffee pot before going home

@bobvdvelde bobvdvelde marked this pull request as ready for review May 20, 2024 13:33
@theoaraujo theoaraujo merged commit 90fc288 into main May 20, 2024
4 checks passed
@theoaraujo theoaraujo deleted the feature/dependency-updates-and-build-fix branch May 20, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants