Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some messages in Italian translation #389

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Fix some messages in Italian translation #389

merged 4 commits into from
Apr 23, 2021

Conversation

cipi1965
Copy link
Contributor

1. Why is this change necessary?

The Italian translation contains some words that does not make sense.

2. What does this change do, exactly?

Rename some words and fix some non sense phrases

3. Please link to the relevant issues (if any).

None

@cipi1965 cipi1965 marked this pull request as draft April 20, 2021 15:52
@PeopleInside
Copy link
Contributor

@cipi1965 thank you! Grazie! This look to be a great job!

@papnoisanjeev
Copy link
Collaborator

@cipi1965

Have you done with the updates for translation (it) or still in progress as i can see you have marked it as draft.

@cipi1965
Copy link
Contributor Author

@papnoisanjeev hey, it's still a draft because i'm still tweaking it. I will ping you as soon as it's ready

@cipi1965 cipi1965 marked this pull request as ready for review April 22, 2021 16:15
@cipi1965
Copy link
Contributor Author

@papnoisanjeev i think it's ready for review

@papnoisanjeev
Copy link
Collaborator

@PeopleInside Please review if everything ok with Italian translation as you are the same language user and have better knowledge about language.

@PeopleInside
Copy link
Contributor

PeopleInside commented Apr 23, 2021

@papnoisanjeev I checked yesterday the new edit from @cipi1965 and looks like a very amazing work. I think you can trust him.
For me looks like everything is good. I think you can pull it.

@cipi1965
Copy link
Contributor Author

@PeopleInside thank you very much! I kept some words in english version because is common use in italian (like Ticket in place of Biglietto that usually mean only train ticket and not support ticket)

@PeopleInside
Copy link
Contributor

@PeopleInside thank you very much! I kept some words in english version because is common use in italian (like Ticket in place of Biglietto that usually mean only train ticket and not support ticket)

I see, is a really good works. Thank you!

@papnoisanjeev
Copy link
Collaborator

@PeopleInside
Ok fine and thanks for your time :)

@cipi1965
I really appreciate your efforts to correct us. thanks !!

@PeopleInside
Copy link
Contributor

@papnoisanjeev will be nice if you can fix the fact customer when see the ticket list after login in his account, doesn't see the status ticket translated as described here: #326 (comment)

@papnoisanjeev
Copy link
Collaborator

@papnoisanjeev will be nice if you can fix the fact customer when see the ticket list after login in his account, doesn't see the status ticket translated as described here: #326 (comment)

Will check it as well.

@papnoisanjeev papnoisanjeev merged commit 15aed9e into uvdesk:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants