Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prv get float #205

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Fix prv get float #205

merged 2 commits into from
Jul 30, 2023

Conversation

ShiCheng-Lu
Copy link
Collaborator

@ShiCheng-Lu ShiCheng-Lu commented Jul 29, 2023 •
edited
Loading

I got the get float backwards. fixed

Bafran
Bafran approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@Bafran Bafran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this while working on pedal too. lgtm

@Bafran Bafran merged commit ff93412 into main Jul 30, 2023
1 check passed
@Bafran Bafran deleted the fix-prv_get_float branch July 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bafran Bafran Bafran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiCheng-Lu @Bafran