Completed tasks #290
Closed
Completed tasks #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akashem06
requested changes
Jul 29, 2024
projects/task2/src/queues1.c
Outdated
| LOG_DEBUG("Write to queue failed!"); | ||
| } | ||
| to_send++; | ||
| if (to_send >= QUEUE_LEN) { |
There was a problem hiding this comment.
The queue sending is correct but this check needs to be fixed. You shouldn't break out of a Tasks while(true) loop
Having all of the logic under a if (to_send < QUEUE_LEN) would work
projects/gpio/src/main.c
Outdated
| gpio_toggle_state(&addr3); | ||
| delay_ms(1000); | ||
| gpio_toggle_state(&addr4); | ||
| delay_ms(1000); |
There was a problem hiding this comment.
Notify check is good!
But all of the gpio_toggle logic should be placed inside of the if(check). Check will return true only if the interrupt is triggered, which is when the gpio's should be toggled. There is also no reason for a 1sec delay after each toggle
Also the buttonAddr cannot and does not need to be toggled, its an input pin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed tasks from FW 101 to 103.