Bootloader #306
Bootloader #306
Conversation
…+ Flash devlopment
Akashem06
force-pushed
the
bootloader
branch
from
810d1b3
to
9327899
Compare
| @@ -15,6 +15,17 @@ proc stm_flash {IMGFILE} { | |||
| reset run | |||
| } | |||
|
|
|||
| proc stm_flash_bootloader_application {IMGFILE} { | |||
| reset halt | |||
| sleep 100 | |||
There was a problem hiding this comment.
what's the purpose of all these sleeps? Is it just a catch all to let things complete? If so, this first one seems to be redundant since you're calling wait_halt 2 right after
projects/bootloader/scripts/main.py
Outdated
|
|
||
|
|
||
| class TestCanDatagram(unittest.TestCase): | ||
| '''Test Can Datagram functions''' |
There was a problem hiding this comment.
just curious, I see that these are copied from FWXIV, is there a reason you changed all the docstrings to single quotes?
There was a problem hiding this comment.
No reason I like single quotes more
| @@ -0,0 +1,29 @@ | |||
| ENTRY(Reset_Handler) | |||
|
|
|||
| _bootloader_size = 8K; | |||
There was a problem hiding this comment.
did you come up with this number after compilation?
There was a problem hiding this comment.
Yes, I initially wanted 4k but it was too small, 8k is good for now
There was a problem hiding this comment.
I'm gonna approve this since you said it works lol. It's a bit too large and I don't have enough context to properly review. Did you say there's a confluence doc though? Ryan's old bootloader page doesn't 1:1 match this and I think it would be better to make things a little more clear here
No description provided.