Fw 999 fw 103 hw kien nguyen #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akashem06
requested changes
Sep 22, 2024
projects/fw_103/src/ads1115.c
Outdated
|
|
||
| StatusCode ads1115_read_raw(ADS1115_Config *config, ADS1115_Channel channel, int16_t *reading) { | ||
| /* TODO: complete function */ | ||
| i2c_read_reg(config->i2c_port, config->i2c_addr, ADS1115_REG_CONVERSION, (uint8_t *) reading, 8); |
There was a problem hiding this comment.
Incorrect read size. (16 bit read so it will be 2 bytes)
projects/fw_103/src/ads1115.c
Outdated
|
|
||
| StatusCode ads1115_read_converted(ADS1115_Config *config, ADS1115_Channel channel, float *reading) { | ||
| /* TODO: complete function */ | ||
| uint16_t reader ; |
There was a problem hiding this comment.
I believe if you pass in an int16_t instead of uint16_t, the value will be signed when returned. That way you won't need your check if (reader <= 32768). Just a simpler approach, don't need changes here. Everything else is good!
projects/fw_103/src/ads1115.c
Outdated
|
|
||
| // Write Config register | ||
| /* TODO: fill out this value */ | ||
| cmd = 0x0011; |
There was a problem hiding this comment.
Incorrect CMD bitset. All bits in the config register should be default (Except for the conversion mode, which you will configure as continuous mode). The default bitset is 0000 0101 1000 0011, as per the datasheet.
Bafran
force-pushed
the
fw_999_fw_103_hw_kien_nguyen
branch
from
3b34f21
to
9daae47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finished FW 103, can you help me look at it?