Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add commitlint and husky dependencies #1

Merged
merged 6 commits into from
Sep 18, 2021

Conversation

hanlinc27
Copy link
Member

@hanlinc27 hanlinc27 commented Sep 18, 2021

Notion ticket link

Ticket Name

Implementation description

Steps to test

  1. Pull changes
  2. Make an edit
  3. Try saving commit without format and should be error
    i.e.

Screen Shot 2021-09-18 at 2 03 28 PM

What should reviewers focus on?

  • If the deps make sense

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hanlinc27 hanlinc27 requested a review from a team September 18, 2021 18:08
@hanlinc27 hanlinc27 self-assigned this Sep 18, 2021
@hanlinc27 hanlinc27 added infra/devops Infrastructure or devops change ready for review labels Sep 18, 2021
@hanlinc27 hanlinc27 merged commit 30658f2 into main Sep 18, 2021
@hanlinc27 hanlinc27 deleted the hanlin/setup-dependencies branch October 14, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra/devops Infrastructure or devops change ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants