Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up frontend pages #19

Merged
merged 7 commits into from
Oct 28, 2021
Merged

chore: clean up frontend pages #19

merged 7 commits into from
Oct 28, 2021

Conversation

hanlinc27
Copy link
Member

@hanlinc27 hanlinc27 commented Oct 16, 2021

Notion ticket link

Clean up Starter Code FE

Implementation description

  • Removed unused route constants on FE
  • Remove unused pages on FE
  • Removed unused CRUD components (i.e. create form, display entities)
  • Remove unused hook example
  • Remove unused utility functions (i.e. CSV Export etc.)
  • Replaced some of the semantic HTML with Chakra components

Screen Shot 2021-10-16 at 3 08 08 PM

Screen Shot 2021-10-16 at 3 08 14 PM

Screen Shot 2021-10-16 at 3 08 22 PM

Steps to test

  1. Pull branch, docker compose down
  2. docker compose up
  3. Check everything renders fine and there are no console errors

What should reviewers focus on?

  • Make sure everything removed can be removed

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hanlinc27 hanlinc27 marked this pull request as ready for review October 16, 2021 19:14
@hanlinc27 hanlinc27 added the frontend Frontend change label Oct 25, 2021
@hanlinc27 hanlinc27 merged commit 993620f into main Oct 28, 2021
@hanlinc27 hanlinc27 deleted the chore/cleanup-frontend branch November 11, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants