-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: landing, login, and sign up welcome screens #21
Conversation
onClick={() => history.push(LANDING_PAGE)} | ||
backgroundColor="transparent" | ||
> | ||
<CloseIcon color="#111111" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be passed in explicitly instead of from the theme provider
return ( | ||
<> | ||
<Header /> | ||
<Container pl="42px" pr="42px" pt="0.5rem"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on extracting this component into its own file to reuse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting 404 error when i click schedule a dropoff button
Screen.Recording.2021-11-03.at.2.57.38.AM.mov
.
thanks for the catch @linnall ! fixed |
Notion ticket link
Welcome Page
Implementation description
09a165dd-3315-4360-a306-fa67d9222ff3.mp4
Steps to test
Checklist