Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing, login, and sign up welcome screens #21

Merged
merged 14 commits into from
Nov 4, 2021
Merged

Conversation

hanlinc27
Copy link
Member

@hanlinc27 hanlinc27 commented Oct 30, 2021

Notion ticket link

Welcome Page

Implementation description

  • Created custom themes based off Figma
  • Add in initial landing screen
09a165dd-3315-4360-a306-fa67d9222ff3.mp4

Steps to test

  1. Verify everything renders properly and please run locally

Screen Shot 2021-11-02 at 12 28 07 AM

Screen Shot 2021-11-02 at 12 28 12 AM

Screen Shot 2021-11-02 at 12 28 16 AM

Screen Shot 2021-11-02 at 12 28 22 AM

Screen Shot 2021-11-02 at 12 28 28 AM

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hanlinc27 hanlinc27 added the frontend Frontend change label Oct 30, 2021
@hanlinc27 hanlinc27 changed the title feat: landing page welcome screen feat: landing, login, and sign up welcome screens Nov 2, 2021
onClick={() => history.push(LANDING_PAGE)}
backgroundColor="transparent"
>
<CloseIcon color="#111111" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be passed in explicitly instead of from the theme provider

return (
<>
<Header />
<Container pl="42px" pr="42px" pt="0.5rem">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on extracting this component into its own file to reuse?

Copy link
Contributor

@Shehryar21 Shehryar21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting 404 error when i click schedule a dropoff button

Screen.Recording.2021-11-03.at.2.57.38.AM.mov

.

@jossmurphy jossmurphy self-requested a review November 4, 2021 00:40
@linnall
Copy link
Contributor

linnall commented Nov 4, 2021

Screen Shot 2021-11-03 at 9 45 36 PM

Not sure if you got to this yet, but I think if you click on the 'x' it would redirect to the login page rather than the home page + back button on login page that redirects to home page

@hanlinc27
Copy link
Member Author

Screen Shot 2021-11-03 at 9 45 36 PM

Not sure if you got to this yet, but I think if you click on the 'x' it would redirect to the login page rather than the home page + back button on login page that redirects to home page

thanks for the catch @linnall ! fixed

@hanlinc27 hanlinc27 merged commit 2d0210b into main Nov 4, 2021
@hanlinc27 hanlinc27 deleted the feat/login-lofi branch November 11, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants