Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backend tests #23

Merged
merged 6 commits into from
Nov 4, 2021
Merged

fix: backend tests #23

merged 6 commits into from
Nov 4, 2021

Conversation

annechung
Copy link
Contributor

@annechung annechung commented Nov 3, 2021 •
edited
Loading

Notion ticket link

Fixing CI tests

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@annechung annechung temporarily deployed to CI November 4, 2021 05:52 Inactive
@annechung annechung temporarily deployed to CI November 4, 2021 06:07 Inactive
@annechung annechung changed the title WIP: fixing backend ci fix: backend tests Nov 4, 2021
@annechung annechung temporarily deployed to CI November 4, 2021 06:32 Inactive
@annechung
Copy link
Contributor Author

ig specifying an environment in a docker-compose.yml file triggers a deployment? not too sure what those are

@hanlinc27 hanlinc27 added ready to merge infra/devops Infrastructure or devops change labels Nov 4, 2021
@annechung annechung temporarily deployed to env November 4, 2021 19:26 Inactive
@annechung annechung merged commit c82ddf3 into main Nov 4, 2021
@annechung annechung deleted the fix/ci-tests branch November 4, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlinc27 hanlinc27 hanlinc27 approved these changes

@Shehryar21 Shehryar21 Shehryar21 approved these changes

Assignees
No one assigned
Labels
infra/devops Infrastructure or devops change ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annechung @hanlinc27 @Shehryar21