Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create scheduling process skeleton #25

Merged
merged 8 commits into from
Nov 8, 2021

Conversation

AmandaMisjuwar
Copy link
Contributor

@AmandaMisjuwar AmandaMisjuwar commented Nov 6, 2021

Notion ticket link

Initial Scheduling Structure - https://www.notion.so/uwblueprintexecs/Initial-Scheduling-Structure-83f15a6202fe476a99524954a8b24fac

Implementation description

  • Created skeleton for scheduling a donation process based on lo-fi Figma designs.
  • Consists of the following pages:
  1. Get started with scheduling a donation
  2. Select date and time
  3. Donation information
  4. Volunteer information
  5. Confirm details
  6. Thank you page

Note 1-5 are using the useStep functionality in /schedule route while 6. Thank You page is its own route /schedule/confirmation

01e5509e-c298-4080-96d3-fb6face6bbb2.mp4

Steps to test

  1. Make sure it compiles with no errors (warnings will be resolved as pages are filled in)
  2. Go to home page and click on 'Schedule a drop off'
  3. Click through steps using the 'Next' button and 'Submit' button and make sure all necessary pages exist. (Components will be filled in)

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Member

@hanlinc27 hanlinc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good skeleton template to work off for implementing the scheduling workflow! 😄

Copy link
Contributor

@Shehryar21 Shehryar21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! For future frontend tickets, please include a screenshot or a video in the PR as well. It would be easier for the people reviewing!

navigation,
}: SchedulingStepProps) => {
const { previous, next } = navigation;
const history = useHistory();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah don't think we need this, we can remove it when working on this page

@AmandaMisjuwar AmandaMisjuwar merged commit de1ed91 into main Nov 8, 2021
@hanlinc27 hanlinc27 deleted the amanda/feat/scheduling-structure branch November 11, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants