Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #3

Merged
merged 4 commits into from
Sep 25, 2021
Merged

docs: update README #3

merged 4 commits into from
Sep 25, 2021

Conversation

Shehryar21
Copy link
Contributor

Notion ticket link

Update Readme

Implementation description

  • Removed unnecessary starter code readme

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Shehryar21 Shehryar21 requested a review from a team September 18, 2021 19:23
@hanlinc27 hanlinc27 changed the title Update-readme docs: update README Sep 18, 2021
README.md Outdated
git tag <semver> <short-hash-of-main-commit>
git push origin --tags
```
The backend runs at http://localhost:5000 and the frontend runs at http://localhost:3000.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
The backend runs at http://localhost:5000 and the frontend runs at http://localhost:3000.
The backend runs at `http://localhost:5000` and the frontend runs at `http://localhost:3000`.

README.md Outdated
@@ -194,6 +126,7 @@ git push -f

### Commits
* Commits should be atomic (guideline: the commit is self-contained; a reviewer could make sense of it even if they viewed the commit diff in isolation)
* Please follow the commitlint guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Please follow the commitlint guidelines
* Please follow the [commitlint](https://www.conventionalcommits.org/en/v1.0.0/) guidelines for writing descriptive commits


Starter Code is an easy to set up, flexible, and customizable bootstrap that aims to encourage best development practices and provide baseline implementations of features common to UW Blueprint projects. 24 different stack combinations are supported, allowing "mix and match" between our most commonly used technologies. For more information on the motivation and design decisions behind Starter Code, please check out the home page of our [documentation site](https://uwblueprint.github.io/starter-code-v2)!

Teams should adopt Starter Code and use it as a foundation to get their projects off the ground faster, and as a guideline for how to structure their applications. We hope Starter Code will help project teams output higher quality and maintainable code, and allow them to focus on building cool, interesting features instead of setting up and doing boilerplate work. Put simply, Starter Code is here to help us deliver more value to our NPO partners.

Copy link
Member

@hanlinc27 hanlinc27 Sep 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Web platform for [Community Fridge KW Donor](https://www.instagram.com/communityfridgekw/?hl=en) Scheduling!

@Shehryar21 Shehryar21 merged commit 506ad9b into main Sep 25, 2021
@hanlinc27 hanlinc27 deleted the shehryar/update-readme branch October 14, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants