Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update validators #31

Merged
merged 2 commits into from
Nov 11, 2021
Merged

fix: update validators #31

merged 2 commits into from
Nov 11, 2021

Conversation

Shehryar21
Copy link
Contributor

@Shehryar21 Shehryar21 commented Nov 11, 2021

Implementation description

Before, not having businessName in auth/register endpoint with donor role ended up creating a user but not donor because businessName is a mandatory field. Change in authAPIValidator fixes that. Also made facebookLink and instagramLink optional.

Steps to test

  1. Send post request to auth/register endpoint without businessName and request would not go through.
  2. Send put request to donor:id endpoint without facebookLink and instagramLink and request should go through.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Shehryar21 Shehryar21 requested a review from a team November 11, 2021 02:26
@Shehryar21 Shehryar21 merged commit f990dea into main Nov 11, 2021
@hanlinc27 hanlinc27 deleted the update-validators branch November 11, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants