Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add header progress bar #33

Merged
merged 7 commits into from
Nov 19, 2021
Merged

feat: Add header progress bar #33

merged 7 commits into from
Nov 19, 2021

Conversation

jossmurphy
Copy link
Contributor

@jossmurphy jossmurphy commented Nov 12, 2021

Notion ticket link

Header Progress Bar Component

Implementation description

  • implemented imported progress bar component, minimal customization
  • note: custom styling has been more effort than it is worth, hopefully this is close enough to what has been requested

image
image

design review: is this design satisfying to the original requirements?

Steps to test

1.Navigate to http://localhost:3000/schedule
2. Hit back and next buttons

What should reviewers focus on?

  • functionality

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jossmurphy jossmurphy changed the title feat: header progress bar feat: Add header progress bar Nov 18, 2021
@jossmurphy jossmurphy marked this pull request as ready for review November 18, 2021 23:11
@hanlinc27 hanlinc27 force-pushed the joss/header-progress-bar branch from 50fbfab to edb5894 Compare November 19, 2021 06:23
@hanlinc27 hanlinc27 merged commit 49f3b51 into main Nov 19, 2021
@hanlinc27 hanlinc27 deleted the joss/header-progress-bar branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants