Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error types #35

Merged
merged 2 commits into from
Nov 16, 2021
Merged

fix: Fix error types #35

merged 2 commits into from
Nov 16, 2021

Conversation

Shehryar21
Copy link
Contributor

@Shehryar21 Shehryar21 commented Nov 14, 2021

Implementation description

https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#unknown-on-catch. This also explains more on why we need unknown for error type

Steps to test

  1. Make sure I didnt break anything, so run docker compose up and then test some endpoints to make sure everything is working fine.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Shehryar21 Shehryar21 changed the title Fix: Fix error types fix: Fix error types Nov 14, 2021
@Shehryar21 Shehryar21 requested a review from a team November 14, 2021 02:19
@Shehryar21 Shehryar21 merged commit 67bdabd into main Nov 16, 2021
@hanlinc27 hanlinc27 deleted the fix-error-types branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants