Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pgadmin service #4

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

akshay2000saxena
Copy link
Contributor

@akshay2000saxena akshay2000saxena commented Sep 23, 2021

Notion ticket link

Ticket Name

Implementation description

  • Added pgAdmin as a service

  • For a detailed guide to set it up: Link

  • Add the following to the .env file in the root directory to get pgadmin set up:

PGADMIN_DEFAULT_EMAIL: admin@admin.com
PGADMIN_DEFAULT_PASSWORD: root

Steps to test

  1. Check if pgAdmin runs locally

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@akshay2000saxena akshay2000saxena requested review from Shehryar21 and a team September 23, 2021 05:42
@hanlinc27 hanlinc27 added the backend Backend change label Sep 25, 2021
@hanlinc27 hanlinc27 changed the title Added pgadmin service feat: added pgadmin service Sep 25, 2021
Copy link
Member

@hanlinc27 hanlinc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!
I did have to change the Host name to an IP Address instead of the pgadmin4_container for it to work though, but I can see the tables 👍🏻
image

@Shehryar21
Copy link
Contributor

Similar to Hanlin, I had to change the Host name to my IP Address or use 172.22.0.1 instead of the pgadmin4_container (which I believe is 172.22.0.5). Do you know why this is happening? Also I get these logs in the terminal. Is there a way to stop them?
image

Copy link
Contributor

@Shehryar21 Shehryar21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akshay2000saxena akshay2000saxena merged commit 8e21b06 into main Oct 2, 2021
@hanlinc27 hanlinc27 deleted the akshay/feat/pgadmin-integration branch October 14, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants