Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: donation views weekly calendar #40

Merged
merged 19 commits into from
Nov 20, 2021

Conversation

akshay2000saxena
Copy link
Contributor

Notion ticket link

Ticket Name

Implementation description

image

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hanlinc27 hanlinc27 changed the title WIP: Akshay/feat/weekly calendar wip: donation views weekly calendar Nov 18, 2021
@akshay2000saxena akshay2000saxena changed the title wip: donation views weekly calendar feat: donation views weekly calendar Nov 20, 2021
Comment on lines +68 to +73
calendarDate: {
fontFamily: "Inter, sans-serif",
fontWeight: "Bold",
fontSize: "20px",
lineHeight: "28px",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
calendarDate: {
fontFamily: "Inter, sans-serif",
fontWeight: "Bold",
fontSize: "20px",
lineHeight: "28px",
},

const currentDate = setDay(week, day.day, { locale });

return (
<Text textStyle="calendarDate">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Text textStyle="calendarDate">
<Text textStyle="desktopBodyBold">


return (
<Container
color="#FAFCFE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color="#FAFCFE"
color="squash.100"

Comment on lines +50 to +52
{" "}
{frequency}{" "}
</Badge>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{" "}
{frequency}{" "}
</Badge>
&nbsp;{frequency}&nbsp;
</Badge>

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 9d03a49):

https://community-fridge-kw--pr40-akshay-feat-weekly-c-9j1ckynk.web.app

(expires Sat, 27 Nov 2021 20:02:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@akshay2000saxena akshay2000saxena merged commit cab977b into main Nov 20, 2021
@hanlinc27 hanlinc27 deleted the akshay/feat/weekly-calendar branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants