-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create custom radio select component #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Functionality works properly!! Made small comments, but feel free to merge it in after looking at those.
value={daypart} | ||
values={dayparts} | ||
isRequired | ||
onChange={(e: any) => handleChange(e, "daypart")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of any, I believe it should be e: React.ChangeEvent<HTMLInputElement>
, same in handleChange
function.
|
||
interface RadioSelectGroupProps { | ||
name: string; | ||
value: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: any; | |
value: string; |
values: string[]; | ||
label: string; | ||
isRequired: boolean; | ||
onChange: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onChange: any; | |
onChange: () => void; |
Visit the preview URL for this PR (updated for commit b51f2aa): https://community-fridge-kw--pr42-amanda-feat-radio-co-emrmau2d.web.app (expires Sat, 27 Nov 2021 20:50:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Notion ticket link
Ticket Name
Implementation description
Steps to test
Screen.Recording.2021-11-17.at.10.49.13.PM.mov
What should reviewers focus on?
Checklist