Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Reuse scheduling components #44

Merged
merged 9 commits into from
Nov 25, 2021
Merged

Conversation

Shehryar21
Copy link
Contributor

@Shehryar21 Shehryar21 commented Nov 19, 2021

Notion ticket link

Closes
Make Scheduling Flow Resuable
Confirm Details Screen

Implementation description

  • Made scheduling components to be reusable so that editing donation would use the same components
    Styling still needs to be worked on

Steps to test

  1. Check normal creating a donation flow. You can use the preview url and use the seeded user to login: email: test@test.org and pw: password123
  2. Edit a scheduled donation which should take to the confirm donation details screen in the scheduling flow
  3. Edit buttons on donation details screen should take the user to the respective screen that they are trying to edit
Untitled.mov

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Shehryar21 Shehryar21 requested a review from a team November 19, 2021 07:48
@Shehryar21 Shehryar21 changed the title Reuse scheduling components refactor: Reuse scheduling components Nov 19, 2021
@Shehryar21 Shehryar21 requested a review from a team November 20, 2021 20:35
@github-actions
Copy link

github-actions bot commented Nov 20, 2021

Visit the preview URL for this PR (updated for commit 1fb4f95):

https://community-fridge-kw--pr44-reuse-scheduling-com-tlf853sl.web.app

(expires Thu, 02 Dec 2021 01:53:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Shehryar21 Shehryar21 self-assigned this Nov 24, 2021
@Shehryar21 Shehryar21 requested a review from hanlinc27 November 25, 2021 00:57
Copy link
Contributor

@annechung annechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Shehryar21 Shehryar21 merged commit 0c6fab3 into main Nov 25, 2021
annechung pushed a commit that referenced this pull request Nov 27, 2021
* finished modularizing scheduling component

* fix volunteer edit navigation

* PR fixes plus cleanup

* remove buttons on edit screen

Co-authored-by: AmandaMisjuwar <37950626+AmandaMisjuwar@users.noreply.github.com>
@hanlinc27 hanlinc27 deleted the reuse-scheduling-components branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants