feat: view donation details popup #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 6b8006e): https://community-fridge-kw--pr54-feat-akshay-view-pop-4ekrrai1.web.app (expires Tue, 07 Dec 2021 20:14:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
hanlinc27
requested changes
Nov 30, 2021
Shehryar21
reviewed
Nov 30, 2021
There was a problem hiding this comment.
On my mac screen, the calendar seems to be overflowing a bit. Shouldnt the end of the calendar align with the navbar at the top. Or is this something you are gonna do after?
Functionality wise, it looks good. Just made one comment on how you are getting the upcoming donation.
Shehryar21
approved these changes
Dec 1, 2021
hanlinc27
approved these changes
Dec 1, 2021
linnall
pushed a commit
that referenced
this pull request
Dec 2, 2021
* Add everything * Test changes * revert docker * All checks passed * address pr comments * update method of getting next drop off
linnall
added a commit
that referenced
this pull request
Dec 9, 2021
* add logic for creating multiple schedules for recurring donations * remove use of await in while loop * feat: Scheduling - Volunteer Information page (#49) * style: update mobile home layout ui (#56) * style: update colors and layout * chore: revert * fix: update landing page copy (#57) * feat: view donation details popup (#54) * Add everything * Test changes * revert docker * All checks passed * address pr comments * update method of getting next drop off * WIP creating multiple schedules logic, fixed logic for getting next recurringDonationId * fix posting incorrect start time, recurringDonationId logic to be fixed * fix logic for daily donations, extended logic to weekly and monthly donations * add tests for recurring donations * frontend: modify width of footer * modify test for creating recurring donation schedules * help * fix merge changes * fix spacing * fix weekly calendar file changes * fix weekly event items I'm so sorry Co-authored-by: Linna Luo <linnaluo@Linnas-MacBook-Pro.local> Co-authored-by: Anne Chung <40839109+annechung@users.noreply.github.com> Co-authored-by: Hanlin Cheng <h62cheng@uwaterloo.ca> Co-authored-by: Akshay Saxena <41586370+akshay2000saxena@users.noreply.github.com> Co-authored-by: Shehryar Suleman <shehryarsuleman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
What should reviewers focus on?
Checklist