style: admin view mobile #58
Conversation
|
Visit the preview URL for this PR (updated for commit 9f9a9b7): https://community-fridge-kw--pr58-akshay-feat-admin-vi-wvtxsrhc.web.app (expires Thu, 09 Dec 2021 07:21:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| </Text> | ||
| )} | ||
| {isMobile && ( | ||
| <Badge |
There was a problem hiding this comment.
Wondering if Badge should be a component...
There was a problem hiding this comment.
it can, you can create a variant for it similar to what we have for the buttons in theme.tsx
akshay2000saxena
added
frontend
| color={`${(colorMap as any)[schedule!.frequency]}.100`} | ||
| backgroundColor={`${(colorMap as any)[schedule!.frequency] | ||
| }.200`} |
There was a problem hiding this comment.
I think the color map needs to be edited to be "One time donation" for the key
There was a problem hiding this comment.
Oh okay, lemme check with the designers to see what they finally decided on
| @@ -46,8 +50,8 @@ const DefaultWeeklyEventItem = ({ | |||
| borderColor="#D8DDE0" | |||
| alignItems="center" | |||
| centerContent | |||
| py="1.5rem" | |||
| px="2rem" | |||
| py={isMobile ? "1.25rem" : "1.5rem"} | |||
There was a problem hiding this comment.
since you're not doing any conditional rendering, I think all of the isMobile can just be
py={{base: "1.25rem", lg: "1.5rem"}} but this is fine!
Notion ticket link
Ticket Name
Implementation description
Steps to test
What should reviewers focus on?
Checklist