Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account info page #61

Merged
merged 7 commits into from
Dec 2, 2021
Merged

feat: account info page #61

merged 7 commits into from
Dec 2, 2021

Conversation

annechung
Copy link
Contributor

@annechung annechung commented Dec 2, 2021 •
edited
Loading

Notion ticket link

My Account Screen

Implementation description

  • account information for donor (view only)
  • a bit different from the designs, went over changes with binal!

Steps to test

  1. log in
  2. navigate to my account page from nav bar
  3. verify the correct information is shown

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@annechung annechung requested a review from a team December 2, 2021 04:46
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit a834d14):

https://community-fridge-kw--pr61-feat-my-account-i9byophu.web.app

(expires Thu, 09 Dec 2021 22:36:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

hanlinc27
hanlinc27 requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@hanlinc27 hanlinc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think the email field got flipped but looks good otherwise!! :)

Shehryar21
Shehryar21 approved these changes Dec 2, 2021
View reviewed changes
frontend/src/components/common/Header.tsx Outdated
@@ -75,7 +77,7 @@ const Header = (): JSX.Element => {
<Link as={ReactLink} to={DASHBOARD_PAGE}>
Scheduled Donations
</Link>
<Link as={ReactLink} to={LANDING_PAGE}>
<Link as={ReactLink} to={ACCOUNT_PAGE}>
{/* update link to account page */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the comment.

@annechung annechung merged commit 3048fbb into main Dec 2, 2021
@annechung annechung deleted the feat/my-account branch December 2, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlinc27 hanlinc27 hanlinc27 approved these changes

@Shehryar21 Shehryar21 Shehryar21 approved these changes

Assignees
No one assigned
Labels
frontend Frontend change ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annechung @hanlinc27 @Shehryar21