Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Creating and Editing Donation Backend Integration, Thank You Screen #63

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

Shehryar21
Copy link
Contributor

@Shehryar21 Shehryar21 commented Dec 4, 2021

Notion ticket link

Scheduling Backend Integration
Changes for scheduling screens when being edited

Implementation description

  • Backend Integration for creating and editing a donation
  • Changed some Types stuff. We had two types for the same scheduling data, so I made that into one and had to make few changes cuz of that.
  • Thank You Screen - Made that part of the scheduling flow steps instead of being on a different route since for start time we need to access formvalues
  • Backend Table change. Made isPickup not mandatory since if u dont require a volunteer, isPickup will be null
  • Changes to other Scheduling screens for editing donation
  • Also changed the get started image from svg to png. For some reason svg took so long to load and browser was getting stuck. Changing to png worked fine

Steps to test

  1. Recreate Backend DB: Remove existing tables and recreate them and then do node seed up
  2. Create a donation following the scheduling steps. Make sure to add valid input. For example for recurring end date input has to be in MM/DD/YYYY so please add it like this since we dont have Frontend validations yet and this will cause errors adding to backend
  3. Check if it added in the donor Dashboard
  4. Try editing the donation

What should reviewers focus on?

  • Make sure i didnt break anything and you can create and edit donation properly

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

Visit the preview URL for this PR (updated for commit 62c0876):

https://community-fridge-kw--pr63-backend-integration-23je46qb.web.app

(expires Sat, 11 Dec 2021 19:18:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Shehryar21 Shehryar21 requested a review from a team December 4, 2021 07:27
@Shehryar21 Shehryar21 self-assigned this Dec 4, 2021
Copy link
Contributor

@annechung annechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it works well! is it possible to get better resolution pictures for the get started/thank you pages?

@Shehryar21
Copy link
Contributor Author

tested locally and it works well! is it possible to get better resolution pictures for the get started/thank you pages?

For getting started, we were using svg but it took so long to load and browser was not responding which is why I changed to png. I downloaded straight from Figma tho.

@annechung
Copy link
Contributor

tested locally and it works well! is it possible to get better resolution pictures for the get started/thank you pages?

For getting started, we were using svg but it took so long to load and browser was not responding which is why I changed to png. I downloaded straight from Figma tho.

Ah yeah exporting from figma drops the quality by a lot, we should ask the designers to send the images to us directly. we can switch those out after this is merged though

@AmandaMisjuwar
Copy link
Contributor

tested locally and it works well! is it possible to get better resolution pictures for the get started/thank you pages?

For getting started, we were using svg but it took so long to load and browser was not responding which is why I changed to png. I downloaded straight from Figma tho.

BTW not sure if you downloaded it as 4x, the image quality would look better if you haven't already! @Shehryar21

@Shehryar21 Shehryar21 merged commit 679ae22 into main Dec 4, 2021
@hanlinc27 hanlinc27 deleted the Backend-Integration branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants