Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redo auth ui validations #64

Merged
merged 27 commits into from
Dec 4, 2021
Merged

fix: redo auth ui validations #64

merged 27 commits into from
Dec 4, 2021

Conversation

hanlinc27
Copy link
Member

@hanlinc27 hanlinc27 commented Dec 4, 2021

Notion ticket link

Auth Error UI
Prelim Email Template Styling
Reroute Home
Auth Desktop Friendly

Implementation description

  • Error UI for signup
  • updating desktop designs
  • updating routes on login
    Screen Shot 2021-11-29 at 3 20 57 AM
    Screen Shot 2021-11-29 at 3 22 39 AM

Screen Shot 2021-11-29 at 3 23 05 AM

What should reviewers focus on?

  • Signup for user is throwing me an error at the moment
  • Lint for backend shows no errors locally not sure why CI is breaking

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

Visit the preview URL for this PR (updated for commit 0abc596):

https://community-fridge-kw--pr64-fix-auth-new-b9t8qz6q.web.app

(expires Sat, 11 Dec 2021 20:28:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@hanlinc27 hanlinc27 merged commit 8204778 into main Dec 4, 2021
@hanlinc27 hanlinc27 deleted the fix/auth-new branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants