Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Style select date time calendar #66

Merged
merged 5 commits into from
Dec 9, 2021
Merged

style: Style select date time calendar #66

merged 5 commits into from
Dec 9, 2021

Conversation

AmandaMisjuwar
Copy link
Contributor

@AmandaMisjuwar AmandaMisjuwar commented Dec 4, 2021 •
edited
Loading

Notion ticket link

Style Select Date Time Calendar

Implementation description

  • Styled calendar (should be mobile-friendly and purple themed)
  • Fixed issue where selecting Early Morning time slots are not saved to form
  • Reset selected dayPart and timeslots when selecting a new date from datepicker

Steps to test

  1. Make sure you can go through the form, fill in the form values, go back and forth the pages without losing any selected values (and selected values must be correct)
  2. After selecting a date, dayPart, and time slot, reselect a new date and all of those options should reset
  3. Note: The calendar dates should be restricted to this week and next week (14 days total, Monday - Sunday)
style.date.picker.mov

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Dec 4, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1a9dddd):

https://community-fridge-kw--pr66-style-select-date-ti-8xg3ptog.web.app

(expires Thu, 16 Dec 2021 01:15:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Shehryar21
Shehryar21 approved these changes Dec 9, 2021
View reviewed changes
frontend/src/components/pages/Scheduling/SelectDateTime.tsx Outdated
@@ -108,6 +112,7 @@ const SelectDateTime = ({

const get12HTimeString = (time: string) => {
const time24Hour = `${new Date(time).getHours().toString()}:00`;
console.log(moment(time24Hour, "HH:mm").format("h:mm A"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@AmandaMisjuwar AmandaMisjuwar merged commit 764475f into main Dec 9, 2021
@hanlinc27 hanlinc27 deleted the style/select-date-time branch December 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shehryar21 Shehryar21 Shehryar21 approved these changes

@hanlinc27 hanlinc27 Awaiting requested review from hanlinc27

@annechung annechung Awaiting requested review from annechung

Assignees
No one assigned
Labels
frontend Frontend change ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmandaMisjuwar @Shehryar21