Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donation dashboard FE/BE changes #69

Merged
merged 8 commits into from
Dec 23, 2021
Merged

Conversation

Shehryar21
Copy link
Contributor

@Shehryar21 Shehryar21 commented Dec 10, 2021

Notion ticket link

Show Donation Cards in Ascending Order by StartTime
Show upcoming donations for next 2 weeks in dashboard and add state when no donations scheduled

Implementation description

  • Change backend scheduling get endpoint to return donations sorted by start time.
  • For get by donorId endpoint, added a weekLimit param that if its not passed in, all donations are returned but if it is, it returns the donations scheduled for those many upcoming weeks

Steps to test

  1. Verify that donations in dashboard are showing in sorted order by start time
  2. Verify that donations are shown for upcoming 2 weeks

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Shehryar21 Shehryar21 requested a review from a team December 10, 2021 06:37
@Shehryar21 Shehryar21 self-assigned this Dec 10, 2021
@Shehryar21 Shehryar21 added backend Backend change frontend Frontend change ready for review labels Dec 10, 2021
@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Visit the preview URL for this PR (updated for commit db7d630):

https://communityfridgekw--pr69-fix-backend-scheduli-p988nyr2.web.app

(expires Thu, 30 Dec 2021 07:03:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Shehryar21 Shehryar21 requested a review from hanlinc27 December 23, 2021 06:46
@Shehryar21 Shehryar21 merged commit ef9efe0 into main Dec 23, 2021
@Shehryar21 Shehryar21 deleted the fix/backend-scheduling branch December 23, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend change changes requested frontend Frontend change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants