Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: begin misc design updates from visual enhancements #89

Merged
merged 5 commits into from
Jan 15, 2022
Merged

style: begin misc design updates from visual enhancements #89

merged 5 commits into from
Jan 15, 2022

Conversation

hanlinc27
Copy link
Member

@hanlinc27 hanlinc27 commented Jan 15, 2022 •
edited
Loading

Brief description. What is this change?

New Figma W22 Design Visual Enhancements

  1. Add radio button to the left of the radio select groups.
    Screen Shot 2022-01-15 at 12 14 20 AM
  2. Change sign-in to button
    Screen Shot 2022-01-15 at 12 16 47 AM
  3. Add login error UI
    image

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages follow conventional commits and are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • The appropriate tests if necessary have been written

@github-actions
Copy link

github-actions bot commented Jan 15, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit d370692):

https://communityfridgekw--pr89-hanlin-misc-cleanup-jsusjylt.web.app

(expires Sat, 22 Jan 2022 05:45:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

linnall
linnall approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@linnall linnall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your changes look good :))

@hanlinc27 hanlinc27 merged commit 33675de into main Jan 15, 2022
@hanlinc27 hanlinc27 deleted the hanlin/misc-cleanup branch January 15, 2022 18:58
@hanlinc27 hanlinc27 restored the hanlin/misc-cleanup branch February 13, 2022 23:27
@hanlinc27 hanlinc27 deleted the hanlin/misc-cleanup branch April 6, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linnall linnall linnall approved these changes

@AmandaMisjuwar AmandaMisjuwar Awaiting requested review from AmandaMisjuwar

Assignees
No one assigned
Labels
frontend Frontend change ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanlinc27 @linnall