Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard updates from visual enhancements #90

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

hanlinc27
Copy link
Member

Brief description. What is this change?

Donor Dashboard Visual Enhancements

Add the updated donation dashboard changes from visual enhancements (P1).

Implementation description. How did you make this change?

Before
Screen Shot 2022-01-16 at 6 49 24 PM
Screen Shot 2022-01-16 at 6 49 09 PM

After

23722ff6-33ba-4d16-8931-b580f231bd08.mp4

Steps to test

  1. Schedule some recurring donations, with and without volunteer requirements
  2. Check if it's close to designs on Figma

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages follow conventional commits and are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • The appropriate tests if necessary have been written

@github-actions
Copy link

github-actions bot commented Jan 16, 2022

Visit the preview URL for this PR (updated for commit 4b07df7):

https://communityfridgekw-staging--pr90-hanlin-dashboard-sty-40uvbcww.web.app

(expires Tue, 25 Jan 2022 02:50:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@xsharonhe xsharonhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Looks a lot like the Figma design. I just wanted to show some behaviour that's showing on my laptop that I can't really figure out why:

  1. Not really vertically aligned (it's aligned in your video though so I'm curious what someone else's computer)

Screen Shot 2022-01-16 at 7 18 12 PM

shows)
  1. In the same screenshot, I have no idea why the one time donation shows the ending date of 1969. This was one I made before the branch so maybe that accounts for why? It works for a new one I created.

Screen Shot 2022-01-16 at 7 20 02 PM

>
{`${startTimeLocal}-${endTimeLocal}`}
</Text>
{volunteerNeeded && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was previously taught that booleans in this format should have the !! ahead of it so: !!volunteerNeeded to account for possibly undefined behaviour - just a nitpick though because I don't know if we will get to this situation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good note! However, !! is usually used to cast a non-boolean variable to a boolean for checking (for instance, a string or a number) --> in our case, since volunteerNeeded is already of type boolean, we don't need to add it. Additionally, this is a mandatory type (you can see the scheduling model) so it'll always have a value :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea just saw that haha woops my bad - thanks for the following up!

default:
return "";
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely nitpick but an extra line here for consistency with the rest of the file?

@hanlinc27 hanlinc27 merged commit a5b8421 into main Jan 19, 2022
@hanlinc27 hanlinc27 deleted the hanlin/dashboard-styling branch January 19, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants