-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract calendar component and refactor scheduling flow #94
Conversation
Visit the preview URL for this PR (updated for commit b7dd31a): https://communityfridgekw-staging--pr94-carissa-refactor-sch-n2wxi48w.web.app (expires Sun, 30 Jan 2022 21:44:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
…/uwblueprint/community-fridge-kw into carissa/refactor-scheduling-flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a really good first pr!!! @carissa-tang
first pass comments, will test it out locally tomorrow or friday! :)
frontend/src/components/pages/Scheduling/DonationInformation.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/pages/Scheduling/DonationInformation.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/pages/Scheduling/VolunteerInformation.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some general thoughts 😄 Except for that one bug, everything is working as intended so that's fantastic! Really nice work 😸
feel free to add to the discussion and agree / disagree with some things i said
…/uwblueprint/community-fridge-kw into carissa/refactor-scheduling-flow
1c1915d
to
7cacb8e
Compare
7cacb8e
to
62dacd4
Compare
Brief description. What is this change?
Scheduling Flow: Extract calendar component
Implementation description. How did you make this change?
Steps to test
Desktop View: https://user-images.githubusercontent.com/69697180/150065707-0ebb5bdc-8727-47d1-a2ab-bbcc6f5ffffa.mp4
Mobile View: https://user-images.githubusercontent.com/69697180/150065486-d421a912-963d-42bb-a499-b04f58014fbb.mov
Update: Steps 2 and 3 are now refactored as well
Checklist