Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci and pr lint github actions #95

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix: ci and pr lint github actions #95

merged 1 commit into from
Jan 21, 2022

Conversation

Shehryar21
Copy link
Contributor

Brief description. What is this change?

Implementation description. How did you make this change?

  • Fix to run ci and pr lint github actions for staging branch

Steps to test

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages follow conventional commits and are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • The appropriate tests if necessary have been written

@Shehryar21 Shehryar21 requested a review from a team January 19, 2022 22:54
xsharonhe
xsharonhe approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@xsharonhe xsharonhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanlinc27 hanlinc27 merged commit b4e158d into staging Jan 21, 2022
@hanlinc27 hanlinc27 deleted the fix/ss/github-workflows branch January 21, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsharonhe xsharonhe xsharonhe approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shehryar21 @xsharonhe @hanlinc27