Add peers attribute to toggle interactor #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheer
reviewed
Sep 21, 2023
| export function toggleX({ as }) { | ||
| return toggle({ as, channels: ['x'] }); | ||
| export function toggleX({ as, ...rest }) { | ||
| return toggle({ as, ...rest, channels: ['x'] }); |
There was a problem hiding this comment.
We can simplify the signature and implementation to:
export function toggleX(options) {
return toggle({ ...options, channels: ['x'] });
}...and similarly for the other modified toggle methods.
jheer
requested changes
Sep 21, 2023
jheer
approved these changes
Sep 22, 2023
|
Thanks @spren9er! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request necessary?
Currently, a toggle interactor — interacting with one mark — will filter out data of other marks in same plot, when used with cross-filter selection.
What does this pull request cover?
peersattribute to toggle interactor (analog to interval interactors)highlight-toggle.yamlexample, which uses nowpeersattribute under the hood to show all text labels when toggling (before, it showed only labels for selected bars)