Push orderby criteria to data cube index queries. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orderbycriteria in generated data cube index queries.highlight-cubeexample to test consistent ordering of cube query results. (thanks @spren9er!)Prior to this PR, any orderby criteria were applied upon data cube creation, but not upon subsequent queries to the resulting data cube index table. This PR reverses the situation: orderby criteria are stripped (ignored) for cube creation, but subsequently applied to all cube index table queries to ensure correct and consistent ordering of result rows.
This change fixes the observed ordering inconsistencies between normal and data cube index query results, fixing known highlight interactor bugs over ordered data. (It does not fix the underlying issue that highlight bit vector queries may have different orderings from other queries if no orderby criteria are given.)
Close #159.