Use orderby, not order. Allow highlight to automatically set orderby. #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which the
highlight
interactor may highlight the wrong items if the data ordering of the visualized data is inconsistent with highlight query results. A workaround was to add sort criteria to ensure consistent ordering. This PR updates thehighlight
interactor to automatically add appropriate orderby criteria to a highlighted mark when needed.Breaking change: This PR also addresses a conflict where the mark-level
order
option (which specified query orderby criteria) can be confused with Observable Plot'sorder
option, which parameterizes internal stacking transforms. This update now uses a non-conflictingorderby
option, leavingorder
as a Plot-specific option. Any existing specifications which use theorder
option at the mark-level will likely need to update to useorderby
instead.Fix #248.