Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use orderby, not order. Allow highlight to automatically set orderby. #265

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

jheer
Copy link
Member

@jheer jheer commented Jan 11, 2024

This PR fixes a bug in which the highlight interactor may highlight the wrong items if the data ordering of the visualized data is inconsistent with highlight query results. A workaround was to add sort criteria to ensure consistent ordering. This PR updates the highlight interactor to automatically add appropriate orderby criteria to a highlighted mark when needed.

Breaking change: This PR also addresses a conflict where the mark-level order option (which specified query orderby criteria) can be confused with Observable Plot's order option, which parameterizes internal stacking transforms. This update now uses a non-conflicting orderby option, leaving order as a Plot-specific option. Any existing specifications which use the order option at the mark-level will likely need to update to use orderby instead.

Fix #248.

@jheer jheer changed the base branch from main to v0.4 January 12, 2024 02:55
@jheer jheer merged commit bac02bd into v0.4 Jan 12, 2024
2 checks passed
@jheer jheer deleted the jh/orderby branch January 12, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight interactor sometimes highlights the wrong thing for large datasets
1 participant