-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add $schema to JSON specs #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about pegging all test specs to a specific version, as this creates an extra point of potential error, requiring regeneration of all examples with every version change. If we still want to include a schema, an alternative option would be to point to latest
.
On the other hand, I can see why it might be nice to have a fixed schema in the published JSON on the website. Not sure that outweighs the other issues here, and we could potentially set schema separately solely for the online published examples.
Finally, the tests are now failing so obviously that needs to be resolved.
FWIW, the JSON specs are auto-generated from the YAML, so you probably shouldn't be editing those files anyway. (And for other files, you can of course add |
Oh neat. I added a setting so we get autocomplete for json as well: #633. Happy to defer to your preference for this pull request. |
Closing out in favor of #633 and to avoid maintenance issues around stale version numbers. |
This enables autocomplete and add explicit versions to the examples.