Fix timeouts in std_ranges tests #2012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inline constexpr std::size_t big_sz = (1<<25) + 10; //32M | ||
| inline constexpr std::size_t big_sz = | ||
| #if PSTL_USE_DEBUG | ||
| (1<<18) + 10; //256K |
There was a problem hiding this comment.
Actually, we are reducing the test coverage here, because some parallel patterns have code differentiation by data sizes, for example __parallel_merge...
I would suggest discussing it offline on one of the next technical meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing 32M elements is too much for the debug mode. Let's stick to 256K elements which is enough to use multiple work-group implementation in case of device offloading.
std_ranges_sort.pass takes >10min on my laptop with 32M elements and ~11sec with 256K elements.